Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(player): refactor 'searchForTrackSelect' to be handled in the spatial navigation. #21

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

CarlosVillasenor
Copy link
Collaborator

Description

Refactor 'searchForTrackSelect' to be handled in the spatial navigation thus cleaning changes inside of 'src/js/control-bar/text-track-controls/caption-settings-menu-item.js'

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@bzizmo bzizmo merged commit e4b6ae2 into spatial-navigation Apr 16, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants